mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 35433: CHECK that checkpointed resources exist on the slave.
Date Thu, 18 Jun 2015 11:48:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/#review88362
-----------------------------------------------------------

Ship it!


I'm happy for you to pass None() as the TaskStatus reason right now as you iterate on a new
one.


src/slave/slave.cpp (line 1371)
<https://reviews.apache.org/r/35433/#comment140848>

    s/fail the slave/fail the task/


- Benjamin Hindman


On June 15, 2015, 12:39 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35433/
> -----------------------------------------------------------
> 
> (Updated June 15, 2015, 12:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> No bug was observed (yet), but realized I forgot about this in the dynamic reservations
patches.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 67732a40ef683cb0188425f0bba8fe8ab83e461c 
> 
> Diff: https://reviews.apache.org/r/35433/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message