mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 35544: containerizer: statically initialize isolator factories
Date Thu, 18 Jun 2015 03:17:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35544/#review88329
-----------------------------------------------------------



src/slave/containerizer/mesos/containerizer.cpp (line 134)
<https://reviews.apache.org/r/35544/#comment140803>

    While your analysis is correct, we need to use `get` here instead since `at` will throw
an exception if the element is not found.


- Michael Park


On June 17, 2015, 12:13 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35544/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 12:13 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced dynamic hashmap creation with c++11's static initialization.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712

> 
> Diff: https://reviews.apache.org/r/35544/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message