mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Review Request 35538: [MESOS-1988] Remove unused drop(...) overload
Date Tue, 16 Jun 2015 21:44:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35538/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-1988
    https://issues.apache.org/jira/browse/MESOS-1988


Repository: mesos


Description
-------

The library (src/scheduler/scheduler.cpp) already does the right thing of not doing anything
and just dropping requests when it is dis-connected from the master. This change just deletes
the unused overload that is no longer being used.

Also note that this does not change the existing driver implementation ( src/sched/sched.cpp
) which sends a "TASK_LOST" back when disconnected from the master. This behavior would be
changed later.

(More info on JIRA)


Diffs
-----

  src/scheduler/scheduler.cpp af18c6bb8bcbe0912246cdf9e84ee183924ea298 

Diff: https://reviews.apache.org/r/35538/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message