mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Review Request 35508: Improve readability in post-review
Date Tue, 16 Jun 2015 12:43:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35508/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos


Description
-------

Section titles now append to the section they lead instead of the one above, i.e.:

```
Running 'rbt post' across all of ...
711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD -> alexander/quickfix/post-review-spacing)
Improve readability in post-review (46 seconds ago)

Creating diff of:
711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD -> alexander/quickfix/post-review-spacing)
Improve readability in post-review

... with parent diff created from:
b5eea1750953671fcd25963e5c5660ff40ca27f1 - Added stream manipulators for the Time object.
(2 minutes ago)
Press enter to continue or 'Ctrl-C' to skip.
```

instead of:

```
Running 'rbt post' across all of ...
711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD -> alexander/quickfix/post-review-spacing)
Improve readability in post-review (46 seconds ago)
Creating diff of:

711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD -> alexander/quickfix/post-review-spacing)
Improve readability in post-review
... with parent diff created from:

b5eea1750953671fcd25963e5c5660ff40ca27f1 - Added stream manipulators for the Time object.
(2 minutes ago)
Press enter to continue or 'Ctrl-C' to skip.
```


Diffs
-----

  support/post-reviews.py ba016f5a12f438e4748ded48d5c0b96facf173cf 

Diff: https://reviews.apache.org/r/35508/diff/


Testing
-------


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message