mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 35494: Added format for template declaration in the styleguide.
Date Tue, 16 Jun 2015 11:27:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35494/
-----------------------------------------------------------

(Updated June 16, 2015, 1:27 p.m.)


Review request for mesos, Bernd Mathiske and Joerg Schad.


Changes
-------

mpark's comments


Bugs: MESOS-2705
    https://issues.apache.org/jira/browse/MESOS-2705


Repository: mesos


Description
-------

The general rule to format templates is to declare them as:

```c++
template <typename T> // notice the space between template and <
class Foo {
  …
};
```

However, the style is not documented anywhere nor it is inherited from the Google style guide.


Diffs (updated)
-----

  docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e 

Diff: https://reviews.apache.org/r/35494/diff/


Testing
-------


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message