mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 35494: Added format for template declaration in the styleguide.
Date Tue, 16 Jun 2015 11:22:54 GMT


> On June 16, 2015, 11:21 a.m., Michael Park wrote:
> > docs/mesos-c++-style-guide.md, line 64
> > <https://reviews.apache.org/r/35494/diff/2/?file=985605#file985605line64>
> >
> >     (1) `s/template/`template`/`
> >     (2) `s/template <Args>/template <typename T>`
> >     (3) `s/template<Args>/template<typename T>`

Yikes, the formatting didn't work there at all.

    (1) Let's wrap 'template' in '`'.
    (2) `s/template <Args>/template <typename T>/`
    (3) `s/template<Args>/template<typename T>/`


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35494/#review88054
-----------------------------------------------------------


On June 16, 2015, 8:17 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35494/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 8:17 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joerg Schad.
> 
> 
> Bugs: MESOS-2705
>     https://issues.apache.org/jira/browse/MESOS-2705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The general rule to format templates is to declare them as:
> 
> ```c++
> template <typename T> // notice the space between template and <
> class Foo {
>   …
> };
> ```
> 
> However, the style is not documented anywhere nor it is inherited from the Google style
guide.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e 
> 
> Diff: https://reviews.apache.org/r/35494/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message