mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 35482: Replace adhoc JSON conversion functions for ResourceStatistics with a protocol buffer to JSON converter.
Date Tue, 16 Jun 2015 00:15:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35482/#review88008
-----------------------------------------------------------


Bad patch!

Reviews applied: [35482]

Failed command: ./support/apply-review.sh -n -r 35482

Error:
 2015-06-16 00:15:18 URL:https://reviews.apache.org/r/35482/diff/raw/ [44012/44012] ->
"35482.patch" [1]
error: patch failed: src/Makefile.am:353
error: src/Makefile.am: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On June 16, 2015, 12:14 a.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35482/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 12:14 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace adhoc JSON conversion functions for ResourceStatistics with a protocol buffer
to JSON converter.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3c44f01f7d22cff6b9e46c2e68997ce5c2773791 
>   src/common/json.hpp PRE-CREATION 
>   src/common/json.cpp PRE-CREATION 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 4c719b186b519fad0c3869dbdae8b60c3a2c20cc

>   src/slave/containerizer/isolators/network/port_mapping.cpp 432b05ce5a99c8239fafc47a6b65d46a0fbac26e

>   src/tests/port_mapping_tests.cpp f8372df74cd71df37de4a2438069ef0ea8878512 
> 
> Diff: https://reviews.apache.org/r/35482/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message