mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 35403: Added the ability to get the peer address of a connected or accepted Socket.
Date Mon, 15 Jun 2015 22:43:43 GMT


> On June 12, 2015, 11:06 p.m., Niklas Nielsen wrote:
> > Maybe add @joris to this review?

This change is pretty trivial, it's symmetric to the existing Socket::address, but I'd be
happy to follow up if he has any feedback! :)


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35403/#review87779
-----------------------------------------------------------


On June 12, 2015, 10:40 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35403/
> -----------------------------------------------------------
> 
> (Updated June 12, 2015, 10:40 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See above.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/network.hpp 6d949c0b9b5bfd2b54be76a08ab2b6970be5d4fa

>   3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b

>   3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 
> 
> Diff: https://reviews.apache.org/r/35403/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message