mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop
Date Mon, 15 Jun 2015 19:07:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33208/#review87958
-----------------------------------------------------------


Hey Robert; BenH helped out and wrote a PoC patch here https://reviews.apache.org/r/35405

In short; it is not safe to delete the detector at this point. The patch above does it in
join() and has a good descriptive block of comment explaining the issue.
What we need to do is try it out and test it.

- Niklas Nielsen


On April 14, 2015, 10:23 p.m., Robert Lacroix wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33208/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 10:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1634
>     https://issues.apache.org/jira/browse/MESOS-1634
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the Mesos Scheduler Driver stops, it does not delete the detector process before
the object is garbage collected, which leaves ZooKeeper connections hanging around unnecessarily.
This deletes the process on stop as well, not only on destruction.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp 66fd2b3146568900356cc48e0f17c6720665ae80 
> 
> Diff: https://reviews.apache.org/r/33208/diff/
> 
> 
> Testing
> -------
> 
> make check, manual testing
> 
> 
> Thanks,
> 
> Robert Lacroix
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message