mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.
Date Mon, 15 Jun 2015 16:04:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35438/#review87928
-----------------------------------------------------------


Patch looks great!

Reviews applied: [35438]

All tests passed.

- Mesos ReviewBot


On June 15, 2015, 2:28 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35438/
> -----------------------------------------------------------
> 
> (Updated June 15, 2015, 2:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Till Toenshoff, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Follow up to RR https://reviews.apache.org/r/35247/, which was not good enough, fixed
only one of two problems.
> 
> Using DeclineOffers() instead of Return() should make the master resend offers so we
can launch tasks. See line 205 below.
> 
> Following Jie's suggestion, no more CHECK_READY inside launchTask(s)(), but we return
a Try instead and follow call sites with EXPECT_SOME(task(s)).
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 8bd5dd847fb189d0eeeaa760d3ec8ce3af1c2392 
> 
> Diff: https://reviews.apache.org/r/35438/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message