mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 35000: Doxygen'ized Subprocess.
Date Sun, 14 Jun 2015 17:15:17 GMT


> On June 4, 2015, 10:20 a.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 141
> > <https://reviews.apache.org/r/35000/diff/1/?file=977410#file977410line141>
> >
> >     Suggestion: maybe we should add what structure this "status" has. It is propagated
to here from an underlying call to waitpid()and associated macros from "wait.h" can be applied,
as for example 'WIFEXITED(status)'.

Great idea!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35000/#review86577
-----------------------------------------------------------


On June 3, 2015, 1:45 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35000/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 1:45 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 37cab7755d2890619b64e1ca09e0b7ad0e72cf76

> 
> Diff: https://reviews.apache.org/r/35000/diff/
> 
> 
> Testing
> -------
> 
> make check
> doxygen ../Doxyfile
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message