mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 35425: libprocess: Use CHECK_NONE.
Date Sat, 13 Jun 2015 14:29:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35425/#review87831
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On June 13, 2015, 2:06 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35425/
> -----------------------------------------------------------
> 
> (Updated June 13, 2015, 2:06 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `grep -r "CHECK([^!].*.isNone())" .` to find the instances that look like `CHECK(x.isNone());`
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/decoder.hpp 56adde07b650984de367fb861d7a496fa37884cb 
> 
> Diff: https://reviews.apache.org/r/35425/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message