mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 35093: Update libprocess once to use synchronized.
Date Sat, 13 Jun 2015 13:51:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35093/#review87819
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/include/process/once.hpp
<https://reviews.apache.org/r/35093/#comment140263>

    We can still wrap this all in synchornized and create a std::unique_lock with the std::adopt_lock
 tag and then do 'lock.release()' after 'cond.wait(lock)'. Let's go with this style for now
so that we can stay consistent with using 'synchronized' everywhere.


- Benjamin Hindman


On June 4, 2015, 10:54 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35093/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 10:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2805
>     https://issues.apache.org/jira/browse/MESOS-2805
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/once.hpp 256ed079e4ff0aab3285eb48a8a10b1ae570bc9b

> 
> Diff: https://reviews.apache.org/r/35093/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message