mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <an...@mesosphere.io>
Subject Re: Review Request 35179: MESOS-1733 Variadic Path Join
Date Fri, 12 Jun 2015 10:32:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35179/
-----------------------------------------------------------

(Updated June 12, 2015, 3:32 a.m.)


Review request for mesos, Adam B and Cody Maloney.


Changes
-------

Removed "Depends on" self


Bugs: MESOS-1733
    https://issues.apache.org/jira/browse/MESOS-1733


Repository: mesos


Description
-------

This change takes an un-complicated/naive route ( no trimming of values etc ) at making path::join(...)
variadic mainly in order to preserve the earlier over-loaded join functionality.

Might have some C++ style issues owing to this being my first commit here.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp d4df6502d1297ea3ad8e2a1e3bb16ea9d7c7913c


Diff: https://reviews.apache.org/r/35179/diff/


Testing
-------

make check + added some additional tests.


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message