mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 13620: Fix the Allocator to recover resources when a slave/framework is removed
Date Fri, 12 Jun 2015 02:04:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13620/#review87673
-----------------------------------------------------------


Bad patch!

Reviews applied: [13620]

Failed command: ./support/apply-review.sh -n -r 13620

Error:
 2015-06-12 02:04:37 URL:https://reviews.apache.org/r/13620/diff/raw/ [8945/8945] -> "13620.patch"
[1]
error: src/master/hierarchical_allocator_process.hpp: does not exist in index
error: patch failed: src/master/master.cpp:564
error: src/master/master.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Aug. 19, 2013, 8:39 p.m., Thomas Marshall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13620/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 8:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-621
>     https://issues.apache.org/jira/browse/MESOS-621
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, when a slave or framework was removed the allocator didn't recover the associated
resources, instead relying on the master calling Allocator::resourcesRecovered for all resources
allocated. This was difficult to reason about and meant that the allocator's state was sometimes
inconsistent with the reality of the cluster (for example, a framework could have resources
allocated to it on a slave that had been removed), so this patch fixes this.
> 
> This also solves a problem with the upcoming implementation of revocation where resources
were recovered from a removed framework and the allocator didn't know what that framework's
role is because it had been removed.
> 
> 
> Diffs
> -----
> 
>   src/master/hierarchical_allocator_process.hpp 183b205 
>   src/master/master.cpp d53b8bb 
> 
> Diff: https://reviews.apache.org/r/13620/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Thomas Marshall
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message