mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 35367: Changed Resourcs JSON model() to combine non-revocable resources and ignore revocable resources.
Date Fri, 12 Jun 2015 00:32:55 GMT


> On June 11, 2015, 4:36 p.m., Vinod Kone wrote:
> > src/tests/common/http_tests.cpp, line 127
> > <https://reviews.apache.org/r/35367/diff/1/?file=983104#file983104line127>
> >
> >     camelcase?

Wrote too much Python lately.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35367/#review87649
-----------------------------------------------------------


On June 11, 2015, 5:32 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35367/
> -----------------------------------------------------------
> 
> (Updated June 11, 2015, 5:32 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2838
>     https://issues.apache.org/jira/browse/MESOS-2838
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> "Combine" means taking the sum of scalars or coalescing ranges and sets of all resources
of the same name regardless of their other attributes.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 7da6e6e8bc1fa1d62fc8be2b5169b68e10392b73 
>   src/common/http.cpp 2ac7fba7a3aac913540f1b09768777393b79284a 
>   src/common/resources.cpp 05969199889c6bc1421c8e5be10c74a50660719f 
>   src/tests/common/http_tests.cpp f087b2313a13c3199b70b3d7feb728e1449a52e7 
>   src/tests/resources_tests.cpp ad12648a08ebc90da6bc9b9aa196fcef5ebe9f11 
> 
> Diff: https://reviews.apache.org/r/35367/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> Added a test `HTTP.ModelResources` and `ResourcesTest.Types` for this.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message