mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 34703: Added stream manipulators for the Time object.
Date Thu, 11 Jun 2015 11:12:25 GMT


> On June 11, 2015, 11:10 a.m., Michael Park wrote:
> > 3rdparty/libprocess/include/process/time.hpp, lines 111-114
> > <https://reviews.apache.org/r/34703/diff/4/?file=980765#file980765line111>
> >
> >     Formatting:
> >     
> >     ```static const char* WEEK_DAYS[] = {
> >            "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat
> >        };
> >     ```

Sorry, not sure what happened there.

I meant

```cpp
static const char* WEEK_DAYS[] = {
    "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"
};
```


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review87550
-----------------------------------------------------------


On June 8, 2015, 3:14 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34703/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 3:14 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Michael Park, Nikita Vetoshkin, and Till Toenshoff.
> 
> 
> Bugs: mesos-708
>     https://issues.apache.org/jira/browse/mesos-708
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds some manipulator classes which allows formatting Time objects to ostreams.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/time.hpp c5ab2a3cfa83590eb6612152ae365dd67f51cea9

>   3rdparty/libprocess/src/tests/time_tests.cpp be314182c65c05d439b81aa5248a71d93f6f0a0b

> 
> Diff: https://reviews.apache.org/r/34703/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message