mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 34976: Added installation instructions for Ubuntu 14.04 and OSX
Date Thu, 11 Jun 2015 10:02:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review87539
-----------------------------------------------------------


Sorry it took me so long to get back to this. I just had a few minor comments/questions, but
you ought to get a Mac user to verify the OSX instructions.


docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139910>

    This was a general comment that came up during our last review meeting, and I wanted to
make a note so it wasn't lost. Apologies if this was confusing to you. Let me explain the
intention in more detail.
    
    _If_ there was content for 12.04 being dropped in favor of the more modern 14.04 instructions,
then it would be better to archive the old instructions than lose them completely. Seems like
no content was dropped, so this is a non-issue here.
    
    Also, we agreed that it would be better to keep a single set of instructions per distro,
only referencing the latest (e.g. Ubuntu LTS) release, rather than having instructions for
multiple versions of the same distro. This echoes my original comment.
    
    It seems like you've acted accordingly, and there is no content lost from 12.04, so no
need to archive. Feel free to drop the issue.



docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139911>

    Why upgrade? Doesn't seem necessary.



docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139912>

    `build-essential` is no longer needed? Or pre-installed in 14.04?



docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139913>

    What about these python packages? Probably still necessary if you don't `configure --disable-python`.



docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139915>

    0.21 and newer? (sasl is 0.14+, maven is 0.18+) Otherwise why call out the version at
all, if you're just going to recommend they install the latest?



docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139917>

    Can you get a Mac user to review/approve these instructions? Maybe @davelester or @nnielsen



docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139918>

    Both of these links go to `https://developer.apple.com/xcode/`
    Is this intentional?
    
    Also "on your Mac" is probably redundant.



docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139919>

    s/deps/dependencies/



docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139894>

    Probably better to recommend j=<number of cores> or j=<#GB RAM>, since j=8
could be overkill on a dual-core or smaller.


- Adam B


On June 2, 2015, 11:44 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 11:44 p.m.)
> 
> 
> Review request for mesos and Dave Lester.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added installation instructions for Ubuntu 14.04 and OSX
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75 
> 
> Diff: https://reviews.apache.org/r/34976/diff/
> 
> 
> Testing
> -------
> 
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message