mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 34703: Added stream manipulators for the Time object.
Date Thu, 11 Jun 2015 08:22:35 GMT


> On June 8, 2015, 2:59 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/include/process/time.hpp, line 150
> > <https://reviews.apache.org/r/34703/diff/3/?file=974298#file974298line150>
> >
> >     Lets think about a good replacement for that class name to make it intuitive
- first thing that came to mind is ```UnixTimestamp```.
> >     
> >     Lets also add an example right here in this comment.

Apparently BenH is OK with leaving the RFC as part of the name.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review87013
-----------------------------------------------------------


On June 8, 2015, 5:14 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34703/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 5:14 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Michael Park, Nikita Vetoshkin, and Till Toenshoff.
> 
> 
> Bugs: mesos-708
>     https://issues.apache.org/jira/browse/mesos-708
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds some manipulator classes which allows formatting Time objects to ostreams.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/time.hpp c5ab2a3cfa83590eb6612152ae365dd67f51cea9

>   3rdparty/libprocess/src/tests/time_tests.cpp be314182c65c05d439b81aa5248a71d93f6f0a0b

> 
> Diff: https://reviews.apache.org/r/34703/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message