mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 34910: Added task validation for task using revocable resources while its executor does not.
Date Thu, 11 Jun 2015 03:30:28 GMT


> On June 3, 2015, 6:08 p.m., Ben Mahler wrote:
> > src/tests/master_validation_tests.cpp, lines 1136-1137
> > <https://reviews.apache.org/r/34910/diff/1/?file=975982#file975982line1136>
> >
> >     I find it nice to reduce "jaggedness" on comments, e.g.:
> >     
> >     ```
> >       // Create a task that uses revocable resources
> >       // while it's executor does not.
> >     ```
> 
> Vinod Kone wrote:
>     I think most of our code just wraps the comments at 70.

That is true, as that is the only hard rule we have (although it's not getting enforced everywhere
:)).

But subjectively, let's try to write readable comments that are less "jagged", in the same
spirit as we do with our source code wrapping! Maybe this means I'm signing up for adding
to the style guide ;)


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34910/#review86449
-----------------------------------------------------------


On June 10, 2015, 11:56 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34910/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 11:56 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2753
>     https://issues.apache.org/jira/browse/MESOS-2753
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enforces the invariant that a task cannot use revocable resources unless its executor
does.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp a74e844b39595deb9d907cc8ab1b8aee622a8765 
>   src/master/validation.cpp 6c9dc040a7966774a1156fc260126a0f0561af28 
>   src/slave/slave.cpp b9fb929684ae582b9133126fefa5a06d4181d836 
>   src/tests/master_validation_tests.cpp dc9e91e120c2af9e72013557730f6a2fbb5b00fe 
> 
> Diff: https://reviews.apache.org/r/34910/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message