mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lily Chen" <l...@mesosphere.io>
Subject Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.
Date Thu, 11 Jun 2015 00:04:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35330/
-----------------------------------------------------------

(Updated June 11, 2015, 12:04 a.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-2797
    https://issues.apache.org/jira/browse/MESOS-2797


Repository: mesos


Description
-------

Capped number of parallel inspect instances on a docker ps call.


Diffs
-----

  src/docker/docker.hpp 7790d0ff9a6b085025f595533c5f46b702447927 
  src/docker/docker.cpp 71383294c6234d08b2156565b170ada329b8e30f 
  src/slave/constants.hpp 84927e589499e989249c217db571bbeb84a88af1 

Diff: https://reviews.apache.org/r/35330/diff/


Testing (updated)
-------

Tweaked /mesos/src/slave/containerizer/docker.cpp DockerContainerizerProcess::recover function
to call a 'docker ps -a' without a prefix. Then ran 'docker run busybox' 1300 times to recreate
failure, failing DockerContainerizerTest.ROOT_DOCKER_Recover and DockerContainerizerTest.ROOT_DOCKER_SkipRecoverNonDocker,
also causing slave to fail when launched. Also tested fix after clearing 'docker ps -a' log
and with 300 instances in 'docker ps -a' log to make sure original functionality not broken.


Thanks,

Lily Chen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message