mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 34910: Added task validation for task using revocable resources while its executor does not.
Date Wed, 10 Jun 2015 23:17:30 GMT


> On June 10, 2015, 10:03 p.m., Jie Yu wrote:
> > src/master/validation.cpp, lines 714-721
> > <https://reviews.apache.org/r/34910/diff/2/?file=982185#file982185line714>
> >
> >     Is this check redundent? Can you calculate the total first and do one check
instead?

I originally just had one. But opted to split the check for a better/concise error message.
I'll just update the error message and have just one check.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34910/#review87465
-----------------------------------------------------------


On June 10, 2015, 7:10 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34910/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 7:10 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2753
>     https://issues.apache.org/jira/browse/MESOS-2753
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enforces the invariant that a task cannot use revocable resources unless its executor
does.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp a74e844b39595deb9d907cc8ab1b8aee622a8765 
>   src/master/validation.cpp 1793b0e16fc36ead147880ee06cda40b23fa0962 
>   src/slave/slave.cpp 98036b2d5f2c765aef4a416c3cbc082df77ab3ac 
>   src/tests/master_validation_tests.cpp dc9e91e120c2af9e72013557730f6a2fbb5b00fe 
> 
> Diff: https://reviews.apache.org/r/34910/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message