mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request 35313: Added slave metrics for revocable resources.
Date Wed, 10 Jun 2015 19:50:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35313/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-2775
    https://issues.apache.org/jira/browse/MESOS-2775


Repository: mesos


Description
-------

Same approach as done in [r/35119/](https://reviews.apache.org/r/35119/) for [MESOS-2776](https://issues.apache.org/jira/browse/MESOS-2776)].

Note that the existing used metric was not ignoring revocable resources.


Diffs
-----

  src/slave/metrics.hpp 6af7f074d4e41225867e482241988bec3a9806e9 
  src/slave/metrics.cpp 7a31ce7e32c1fd61256927cd37d84a646bf5dbda 
  src/slave/slave.hpp 4d2c31688b19f101ec851c0d94e7d45aa2f8a76e 
  src/slave/slave.cpp 98036b2d5f2c765aef4a416c3cbc082df77ab3ac 

Diff: https://reviews.apache.org/r/35313/diff/


Testing
-------

Manual testing, I will follow up to get this tested within vinod/jie's integration tests.

Note that in the process of testing this, I realized that the command executor leads to a
mixing of revocable / non-revocable resources in the slave. Will file a ticket.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message