mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bartek Plotka" <bwplo...@gmail.com>
Subject Re: Review Request 35281: Added QoS module loader to ::create() factory.
Date Wed, 10 Jun 2015 16:15:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35281/#review87421
-----------------------------------------------------------

Ship it!



src/slave/qos_controller.cpp
<https://reviews.apache.org/r/35281/#comment139742>

    Reorder.


- Bartek Plotka


On June 10, 2015, 1:09 a.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35281/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 1:09 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu.
> 
> 
> Bugs: MESOS-2703
>     https://issues.apache.org/jira/browse/MESOS-2703
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/qos_controller.cpp 81c4b3e658902be0438f42d9e86911e424828a73 
> 
> Diff: https://reviews.apache.org/r/35281/diff/
> 
> 
> Testing
> -------
> 
> make check
> Tested new example module manually, since we don't have a good type param'ed test for
resource estimator and qos controller yet.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message