mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 30952: Adding scheduler validations to master
Date Wed, 10 Jun 2015 03:04:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30952/#review87343
-----------------------------------------------------------


Patch looks great!

Reviews applied: [30952]

All tests passed.

- Mesos ReviewBot


On June 10, 2015, 12:08 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30952/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 12:08 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2290
>     https://issues.apache.org/jira/browse/MESOS-2290
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> There is a scheduler validation (https://github.com/apache/mesos/blob/master/src/scheduler/scheduler.cpp#L275)
missing in master. See motivation on MESOS-2288.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp e91e881 
>   src/master/validation.cpp 1793b0e 
>   src/sched/sched.cpp 8c366ec 
>   src/scheduler/scheduler.cpp f613ca4 
> 
> Diff: https://reviews.apache.org/r/30952/diff/
> 
> 
> Testing
> -------
> 
> make check and distcheck. Tests will be added with new HTTP API endpoints tests.
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message