mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 35270: make a bunch of JSONP callback URLs in mesos UI protocol-relative
Date Wed, 10 Jun 2015 00:38:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35270/#review87326
-----------------------------------------------------------


Patch looks great!

Reviews applied: [35270]

All tests passed.

- Mesos ReviewBot


On June 9, 2015, 11:31 p.m., Oliver Nicholas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35270/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 11:31 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1825
>     https://issues.apache.org/jira/browse/MESOS-1825
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> make a bunch of JSONP callback URLs in mesos UI protocol-relative
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js 93846940ddbbc9f25de9a41f10c899c16e564d88

>   src/webui/master/static/js/services.js 8403aad9b2586ac3c1bea3f75ca38f6f907087a2 
> 
> Diff: https://reviews.apache.org/r/35270/diff/
> 
> 
> Testing
> -------
> 
> manual; are there tests for this stuff?
> 
> 
> Thanks,
> 
> Oliver Nicholas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message