mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.
Date Tue, 09 Jun 2015 18:11:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35247/#review87235
-----------------------------------------------------------



src/tests/fetcher_cache_tests.cpp
<https://reviews.apache.org/r/35247/#comment139554>

    reorder



src/tests/fetcher_cache_tests.cpp
<https://reviews.apache.org/r/35247/#comment139559>

    While this looks good as a temporary fix, what is the long term strategy here?
    
    I really don't like setting expectations in SetUp() or TearDown() because it's really
hard to reason about in the individual tests. For example, why did you set expecations on
registered and offers but not others? I prefer to move these expectations to tests. 
    
    Also, this SetUp() is doing too much (starting slave, starting master, constructing scheduler
but not starting it, setting some expectations) and there is no documentation for it!



src/tests/fetcher_cache_tests.cpp
<https://reviews.apache.org/r/35247/#comment139560>

    Why not just do AWAIT_READY(offers)?


- Vinod Kone


On June 9, 2015, 9:32 a.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35247/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 9:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-2815, MESOS-2829 and MESOS-2831
>     https://issues.apache.org/jira/browse/MESOS-2815
>     https://issues.apache.org/jira/browse/MESOS-2829
>     https://issues.apache.org/jira/browse/MESOS-2831
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.
> 
> Installed a default response that provides teporary cover for this mocked method until
we install more interesting callbacks later. This prevents gmock from complaining about an
"uninteresting gmock call", which led to a variety of tests failing due to offers not getting
through subsequently.
> 
> All fetcher cache tests have been affected by this race and should be fixed in this regard
now.
> 
> (Also fixed some typos.)
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp cbd44b98d19953d174fac977f509d4900a37481f 
> 
> Diff: https://reviews.apache.org/r/35247/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message