mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Brett" <pau...@twopensource.com>
Subject Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.
Date Tue, 09 Jun 2015 17:44:27 GMT


> On June 9, 2015, 5:03 p.m., Cong Wang wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, line 124
> > <https://reviews.apache.org/r/35229/diff/1/?file=980896#file980896line124>
> >
> >     TRAFFIC_CONTROL_STATISTICS is too generic, I don't see what it means from the
name.

The name matches the protocol buffer message name in include/mesos/mesos.proto.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35229/#review87224
-----------------------------------------------------------


On June 9, 2015, 5:29 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35229/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 5:29 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2332
>     https://issues.apache.org/jira/browse/MESOS-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Report per-container metrics for network bandwidth throttling to the slave.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 4c719b186b519fad0c3869dbdae8b60c3a2c20cc

>   src/slave/containerizer/isolators/network/port_mapping.cpp d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f

> 
> Diff: https://reviews.apache.org/r/35229/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message