mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bartek Plotka" <bwplo...@gmail.com>
Subject Re: Review Request 35157: Added unit tests for fetching ResourceUsage in both QoS Controller and Resource Estimator .
Date Tue, 09 Jun 2015 17:39:41 GMT


> On June 9, 2015, 5:26 p.m., Niklas Nielsen wrote:
> > Hey Bartek,
> > 
> > Let's await further work on this ticket before we have resolved the overall approach
for this small patch set (taken that the resource statistics object is planned to change).

You mean, these 3 fields wich change their names? 

Ok, however this the argument for using protobuf serialization then *operator ==* to compare
messages (: We wouldn't have to change the implementation of comparision..
IF, of course, google serialization is fast enough.. ((:


- Bartek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35157/#review87229
-----------------------------------------------------------


On June 9, 2015, 12:17 a.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35157/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 12:17 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod
Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for QoS Controller and ResourceEstimator fetching ResoruceUsage from ResourceMonitor.
> 
> This is the unit test for https://reviews.apache.org/r/34980/ and https://reviews.apache.org/r/35164/
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 52380c2461841026ee492797b4d8081f944f7b7b 
>   src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b 
>   src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 
>   src/tests/mesos.cpp dff45b0d3bf9ef53f19575ab3d90a0b223755d6a 
>   src/tests/oversubscription_tests.cpp afd7ff4f2b50cb20cc2c8865b655ad1f8eb0c8b7 
> 
> Diff: https://reviews.apache.org/r/35157/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message