mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 35118: Made updateSlave() update its 'totalResources'.
Date Tue, 09 Jun 2015 17:36:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35118/#review87234
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/35118/#comment139552>

    Isn't this a bit harsh? Shouldn't we log a warning and return instead? Also, could this
be done earlier on?



src/master/master.cpp
<https://reviews.apache.org/r/35118/#comment139553>

    Does it make sense to point to some documentation (if it exists already, or inline) about
how this resource math will work?


- Niklas Nielsen


On June 5, 2015, 2:09 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35118/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 2:09 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2776
>     https://issues.apache.org/jira/browse/MESOS-2776
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - This way Master::Slave::totalResources includes revocable resources, which we need
for metrics for revocable resources.
> - Changed updateSlave() argument to use `const Resources& oversubscribedResources`
instead of `const std::vector<Resource>& oversubscribedResources` because `Resources`
provides convenience methods such as `revocable()`.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp deeb0d8c87a13315206556e1d0974cdd13e8224f 
>   src/master/master.cpp be0db42da3c59761aa154439653d715556465256 
> 
> Diff: https://reviews.apache.org/r/35118/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message