mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.
Date Tue, 09 Jun 2015 09:32:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35247/
-----------------------------------------------------------

(Updated June 9, 2015, 2:32 a.m.)


Review request for mesos, Benjamin Hindman, Till Toenshoff, and Vinod Kone.


Changes
-------

Corrected bug number.


Bugs: MESOS-2815, MESOS-2829 and MESOS-2831
    https://issues.apache.org/jira/browse/MESOS-2815
    https://issues.apache.org/jira/browse/MESOS-2829
    https://issues.apache.org/jira/browse/MESOS-2831


Repository: mesos


Description
-------

Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

Installed a default response that provides teporary cover for this mocked method until we
install more interesting callbacks later. This prevents gmock from complaining about an "uninteresting
gmock call", which led to a variety of tests failing due to offers not getting through subsequently.

All fetcher cache tests have been affected by this race and should be fixed in this regard
now.

(Also fixed some typos.)


Diffs
-----

  src/tests/fetcher_cache_tests.cpp cbd44b98d19953d174fac977f509d4900a37481f 

Diff: https://reviews.apache.org/r/35247/diff/


Testing
-------

make check


Thanks,

Bernd Mathiske


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message