mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 34921: Code Refactor: float the bytes to get rid of the truncate fraction part in function datasize.
Date Tue, 09 Jun 2015 01:50:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34921/#review87117
-----------------------------------------------------------



src/cli/mesos-ps
<https://reviews.apache.org/r/34921/#comment139443>

    Do you still need the fraction on "1024.0" with this? Maybe a note is needed:
    
    ```
    // Ensure bytes is treated as floating point for the math below.
    bytes = float(bytes)
    
    ...
    ```


- Ben Mahler


On June 2, 2015, 3:28 a.m., weitao zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34921/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 3:28 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Code Refactor: float the bytes to get rid of the truncate fraction part in function datasize.
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos-ps 8ca7a64d0ab6f0b8db823ca95d5f7500487b8753 
> 
> Diff: https://reviews.apache.org/r/34921/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> weitao zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message