mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bartek Plotka" <bwplo...@gmail.com>
Subject Re: Review Request 35157: Added unit tests for fetching ResourceUsage in both QoS Controller and Resource Estimator .
Date Tue, 09 Jun 2015 00:25:22 GMT


> On June 8, 2015, 10:38 p.m., Niklas Nielsen wrote:
> > src/tests/oversubscription_tests.cpp, line 582
> > <https://reviews.apache.org/r/35157/diff/3/?file=980318#file980318line582>
> >
> >     Why copy the offer?

Because we use it several time, however i didn't notice that it wasn't consistent - sometimes
i used *offer*, sometimes *offer.get()[0]*. Fixed now.


- Bartek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35157/#review87074
-----------------------------------------------------------


On June 9, 2015, 12:17 a.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35157/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 12:17 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod
Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for QoS Controller and ResourceEstimator fetching ResoruceUsage from ResourceMonitor.
> 
> This is the unit test for https://reviews.apache.org/r/34980/ and https://reviews.apache.org/r/35164/
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 52380c2461841026ee492797b4d8081f944f7b7b 
>   src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b 
>   src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 
>   src/tests/mesos.cpp dff45b0d3bf9ef53f19575ab3d90a0b223755d6a 
>   src/tests/oversubscription_tests.cpp afd7ff4f2b50cb20cc2c8865b655ad1f8eb0c8b7 
> 
> Diff: https://reviews.apache.org/r/35157/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message