mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 29406: Introduce libevent ssl socket.
Date Mon, 08 Jun 2015 12:58:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29406/
-----------------------------------------------------------

(Updated June 8, 2015, 12:58 p.m.)


Review request for Michael Park.


Changes
-------

fixed issues.
rebased.


Bugs: MESOS-1913
    https://issues.apache.org/jira/browse/MESOS-1913


Repository: mesos


Description
-------

Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New environment variables:
USE_SSL=(0,1)
SSL_CERT=(path to certificate)
SSL_KEY=(path to key)
SSL_VERIFY_CERT=(0,1)
SSL_REQUIRE_CERT=(0,1)
SSL_CA_DIR=(path to CA directory)
SSL_CA_FILE=(path to CA file)

TODO:
Restrict SSL version more tightly
Track down leak in crypto from accept


Diffs (updated)
-----

  3rdparty/libprocess/Makefile.am 489ce359f383d819299335cbaa8c95724b0c6ac2 
  3rdparty/libprocess/include/process/socket.hpp b8c2274de535ac473e49a09165b601c96d3ebe8b

  3rdparty/libprocess/src/libevent.hpp f6cc72178613a30446629532a773afccfd404212 
  3rdparty/libprocess/src/libevent.cpp fb038597358135a06c1927d079cb7cb09fea7452 
  3rdparty/libprocess/src/libevent_ssl_socket.hpp PRE-CREATION 
  3rdparty/libprocess/src/libevent_ssl_socket.cpp PRE-CREATION 
  3rdparty/libprocess/src/openssl.hpp PRE-CREATION 
  3rdparty/libprocess/src/openssl.cpp PRE-CREATION 
  3rdparty/libprocess/src/process.cpp d1b4d469a11abc618c1406bce602300dd9793b58 
  3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 

Diff: https://reviews.apache.org/r/29406/diff/


Testing
-------

make check (uses non-ssl socket)
benchmarks using ssl sockets
master, slave, framework, webui launch with ssl sockets


Thanks,

Joris Van Remoortere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message