mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 33057: Added secret check to CRAM-MD5 authenticatee.
Date Mon, 08 Jun 2015 10:37:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33057/#review87009
-----------------------------------------------------------


Patch looks great!

Reviews applied: [32850, 33057]

All tests passed.

- Mesos ReviewBot


On June 8, 2015, 9:42 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33057/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 9:42 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-2608
>     https://issues.apache.org/jira/browse/MESOS-2608
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Updating authenticatee to check for secret within credential. Adding a test verifying
immediate authenticatee failure when secret is missing.
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
>   src/tests/cram_md5_authentication_tests.cpp 9923023 
> 
> Diff: https://reviews.apache.org/r/33057/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message