mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 33339: Add a Java example framework to test persistent volumes.
Date Sun, 07 Jun 2015 07:48:24 GMT


> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
> > src/examples/java/TestPersistentVolumeFramework.java, line 110
> > <https://reviews.apache.org/r/33339/diff/10/?file=941652#file941652line110>
> >
> >     here too

here could not remove because `j` is used in `remains.set(j, newRemain);`,


> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
> > src/examples/java/TestPersistentVolumeFramework.java, lines 112-116
> > <https://reviews.apache.org/r/33339/diff/10/?file=941652#file941652line112>
> >
> >     this is really hard to 'parse'; also I don't really like to see so many `continue`
makes it difficult to follow the flow of the loop
> >     
> >     Could we please reverse the condition and have the pattern of:
> >     ```
> >     if (a && b &&c) {
> >       // do something
> >     }
> >     ```
> >     this also forces you to have a `break` (I think?) further down.
> >     
> >     Following the logic of this nested for-loop is really hard.

In fact, this snippet is convert from src/common/resources.cpp. So let me think whether a
better way to implement it.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33339/#review86113
-----------------------------------------------------------


On May 18, 2015, 4:42 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33339/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 4:42 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-2610
>     https://issues.apache.org/jira/browse/MESOS-2610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add a Java example framework to test persistent volumes.
> 
> 
> Diffs
> -----
> 
>   configure.ac 7f9e52916b9d78f2bbff9d6ed9871444a0fda629 
>   src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
>   src/examples/java/TestPersistentVolumeFramework.java PRE-CREATION 
>   src/examples/java/test-persistent-volume-framework.in PRE-CREATION 
>   src/tests/examples_tests.cpp f85b81562158c5499e9804d8d7b6811bb0a3ef16 
>   src/tests/java_persistent_volume_framework_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33339/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message