mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 34984: Added help for files
Date Fri, 05 Jun 2015 21:54:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34984/#review86849
-----------------------------------------------------------

Ship it!


I will make the change for you below. Thanks Aditi!


src/files/files.cpp
<https://reviews.apache.org/r/34984/#comment138950>

    Should be:
    
    ```
    using process::DESCRIPTION;
    using process::HELP;
    using process::TLDR;
    using process::USAGE;
    using process::wait; // Necessary on some OS's to disambiguate.
    ```
    
    Underneath 'using namespace process;' :)



src/files/files.cpp
<https://reviews.apache.org/r/34984/#comment138947>

    s/Path/path/


- Niklas Nielsen


On June 4, 2015, 2:40 a.m., Aditi Dixit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34984/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 2:40 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2277
>     https://issues.apache.org/jira/browse/MESOS-2277
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added help for files
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp ce02411c5e579d7551b4325ec141fd89e4ee7255 
> 
> Diff: https://reviews.apache.org/r/34984/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message