mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Review Request 35118: Made updateSlave() update its 'totalResources'.
Date Fri, 05 Jun 2015 21:09:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35118/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-2776
    https://issues.apache.org/jira/browse/MESOS-2776


Repository: mesos


Description
-------

- This way Master::Slave::totalResources includes revocable resources, which we need for metrics
for revocable resources.
- Changed updateSlave() argument to use `const Resources& oversubscribedResources` instead
of `const std::vector<Resource>& oversubscribedResources` because `Resources` provides
convenience methods such as `revocable()`.


Diffs
-----

  src/master/master.hpp deeb0d8c87a13315206556e1d0974cdd13e8224f 
  src/master/master.cpp be0db42da3c59761aa154439653d715556465256 

Diff: https://reviews.apache.org/r/35118/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message