mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 34970: Cleaned up and generalized NoExecutorScheduler to be more configurable.
Date Fri, 05 Jun 2015 19:41:50 GMT


> On June 5, 2015, 6:24 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [34968, 34969, 34970]
> > 
> > Failed command: ./support/apply-review.sh -n -r 34970
> > 
> > Error:
> >  2015-06-05 06:24:06 URL:https://reviews.apache.org/r/34970/diff/raw/ [16370/16370]
-> "34970.patch" [1]
> > error: patch failed: src/examples/no_executor_framework.cpp:16
> > error: src/examples/no_executor_framework.cpp: patch does not apply
> > Failed to apply patch

Interesting, this shouldn't have applied the previous two reviews since [MESOS-1881](https://issues.apache.org/jira/browse/MESOS-1881)
is resolved.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34970/#review86767
-----------------------------------------------------------


On June 5, 2015, 5:52 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34970/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 5:52 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-2655
>     https://issues.apache.org/jira/browse/MESOS-2655
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now the NoExecutorScheduler can take a custom command, as well as the resources for the
task and how many tasks to run.
> 
> This allows us to continue using it for an end-to-end test as part of make check, but
also allows it to be used against a cluster in a long-lived fashion.
> 
> 
> Diffs
> -----
> 
>   src/examples/no_executor_framework.cpp 37001c389f31f9f1dafe6d7f3eb17adc2e369057 
>   src/tests/no_executor_framework_test.sh d2d395595b778bc543e1baaa0fd415dc622b647f 
>   src/tests/script.cpp 515e3141e1d517da4cfc1421d5301d0a3bd6ad51 
> 
> Diff: https://reviews.apache.org/r/34970/diff/
> 
> 
> Testing
> -------
> 
> The existing no executor framework test picks this up.
> 
> Since we do not have an non-zero estimator yet, I modified the slave to send revocable
resources in order to manually test the revocable case.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message