mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 33159: Pump updateFramework through Allocator from Master.
Date Fri, 05 Jun 2015 18:15:42 GMT


> On June 5, 2015, 5:42 p.m., Vinod Kone wrote:
> > src/master/allocator/mesos/hierarchical.hpp, lines 455-456
> > <https://reviews.apache.org/r/33159/diff/4/?file=979945#file979945line455>
> >
> >     I don't follow. Why are these CHECKs? Is there currently code in the master
that guarantees that these checks won't fail?

actually nm. looks like this is being called with framework->info in the master and not
with the frameworkinfo that a framework re-registers with.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33159/#review86818
-----------------------------------------------------------


On June 5, 2015, 1:35 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33159/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 1:35 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-2615 and MESOS-703
>     https://issues.apache.org/jira/browse/MESOS-2615
>     https://issues.apache.org/jira/browse/MESOS-703
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Follow up of 32961 where we add the 'updateFramework' function to the allocator.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp 8347cfaf6abce155a777484970e595e6b141bb87 
>   src/master/allocator/mesos/allocator.hpp b57b03daf992082ec7c731666699ab2574bf7993 
>   src/master/allocator/mesos/hierarchical.hpp 44fbccaf72b65251095f69b68627d0efa58707d4

>   src/master/master.cpp be0db42da3c59761aa154439653d715556465256 
>   src/tests/mesos.hpp 86660ac4d7476bc6cc077fc2d474c4a9ac81c031 
> 
> Diff: https://reviews.apache.org/r/33159/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message