mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 34256: Added Path::dirname() and Path::basename().
Date Fri, 05 Jun 2015 13:03:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34256/
-----------------------------------------------------------

(Updated June 5, 2015, 1:03 p.m.)


Review request for mesos and Cody Maloney.


Changes
-------

Some simplification, added more comments and did a rebase.


Bugs: MESOS-1303
    https://issues.apache.org/jira/browse/MESOS-1303


Repository: mesos-incubating


Description
-------

Introducing Path::dirname() and Path::basename() as a thread safe replacement of the respective
system functions. Also contains new tests covering corner cases.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp d4df650 
  3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp cf35412 

Diff: https://reviews.apache.org/r/34256/diff/


Testing
-------

make check (including new tests).

Result comparison to match ::dirname and ::basename on interesting cases.


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message