mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 35028: Added a fixed resource estimator.
Date Thu, 04 Jun 2015 17:33:04 GMT


> On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote:
> > src/slave/resource_estimator.cpp, lines 46-48
> > <https://reviews.apache.org/r/35028/diff/1/?file=977720#file977720line46>
> >
> >     How about wrapping like:
> >     
> >     ```
> >         return Error(
> >             "Could not create resource estimator module '" + type.get() + "': "
+
> >             module.error());
> >     
> >     ```
> >     
> >     or
> >     
> >     ```
> >         return Error(
> >             "Could not create resource estimator module '" + type.get() +
> >             "': " + module.error());
> >     
> >     ```
> >     
> >     There should be enough space :)

Done.


> On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote:
> > src/slave/resource_estimators/fixed.cpp, line 146
> > <https://reviews.apache.org/r/35028/diff/1/?file=977721#file977721line146>
> >
> >     We could consider to capitalize this as it is a name :) i.e. 'Fixed Resource
Estimator Module'

Done.


> On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote:
> > src/tests/oversubscription_tests.cpp, line 66
> > <https://reviews.apache.org/r/35028/diff/1/?file=977722#file977722line66>
> >
> >     We have const char* in for example https://github.com/apache/mesos/blob/master/src/tests/hook_tests.cpp#L78
> >     Want to do that instead?

I thought we decided to use char[] consistently? That's what we've been doing in isolators.

Should we make a decision and change that in the style guide?

cc Ben Mahler, Vinod Kone


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35028/#review86502
-----------------------------------------------------------


On June 3, 2015, 10:05 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35028/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 10:05 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2791
>     https://issues.apache.org/jira/browse/MESOS-2791
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a fixed resource estimator. The actual implementation is a stub for now.
> 
> I made it a module so that we can leverage the Parameters to set it up (instead of passing
in a slave flag).
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 66030c4b211ea61e97e62c35ec1821e0958f9787 
>   src/slave/resource_estimator.cpp 5aaf3052ff1f745408b9fabced3b76ed5424acfa 
>   src/slave/resource_estimators/fixed.cpp PRE-CREATION 
>   src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/35028/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message