mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 35000: Doxygen'ized Subprocess.
Date Thu, 04 Jun 2015 10:20:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35000/#review86577
-----------------------------------------------------------



3rdparty/libprocess/include/process/subprocess.hpp
<https://reviews.apache.org/r/35000/#comment138631>

    Nit: Capitalized sentence start after ", and". This was there before, but now is a great
opportunity to clean it up.



3rdparty/libprocess/include/process/subprocess.hpp
<https://reviews.apache.org/r/35000/#comment138632>

    Suggestion: delete "Helper that". (Everywhere)



3rdparty/libprocess/include/process/subprocess.hpp
<https://reviews.apache.org/r/35000/#comment138634>

    Suggestion: maybe we should add what structure this "status" has. It is propagated to
here from an underlying call to waitpid()and associated macros from "wait.h" can be applied,
as for example 'WIFEXITED(status)'.


- Bernd Mathiske


On June 3, 2015, 6:45 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35000/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 6:45 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 37cab7755d2890619b64e1ca09e0b7ad0e72cf76

> 
> Diff: https://reviews.apache.org/r/35000/diff/
> 
> 
> Testing
> -------
> 
> make check
> doxygen ../Doxyfile
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message