mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 35038: Updated slave to query resource estimator whenever it wants to forward an update.
Date Wed, 03 Jun 2015 23:44:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35038/#review86514
-----------------------------------------------------------

Ship it!



src/slave/slave.cpp
<https://reviews.apache.org/r/35038/#comment138572>

    Why CHECK instead of logging and retry? So returning a failure in the resource estimator
will crash the slave?


- Jie Yu


On June 3, 2015, 11:20 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35038/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 11:20 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2808
>     https://issues.apache.org/jira/browse/MESOS-2808
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of 2 loops, we just use one loop now. See the bug for additonal details.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 245ea062a56461d96ee3055be1c93ec508d1bec7 
>   src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
>   src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/35038/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message