mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 35028: Added a fixed resource estimator.
Date Wed, 03 Jun 2015 23:30:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35028/#review86507
-----------------------------------------------------------



src/slave/resource_estimators/fixed.cpp
<https://reviews.apache.org/r/35028/#comment138565>

    Since the slave now asks the estimator everytime it wants to forward an update and doesn't
store a cached value, it makes sense for the estimators to always respond with a value instead
of a pending future. 
    
    For example, if the slave gets disconnected immediately after it gets an estimate from
the estimator, it might query the estimator again.



src/slave/resource_estimators/fixed.cpp
<https://reviews.apache.org/r/35028/#comment138562>

    why not let the process handle this? that way you don't have to maintain a copy?


- Vinod Kone


On June 3, 2015, 10:05 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35028/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 10:05 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2791
>     https://issues.apache.org/jira/browse/MESOS-2791
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a fixed resource estimator. The actual implementation is a stub for now.
> 
> I made it a module so that we can leverage the Parameters to set it up (instead of passing
in a slave flag).
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 66030c4b211ea61e97e62c35ec1821e0958f9787 
>   src/slave/resource_estimator.cpp 5aaf3052ff1f745408b9fabced3b76ed5424acfa 
>   src/slave/resource_estimators/fixed.cpp PRE-CREATION 
>   src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/35028/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message