mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chi Zhang" <chzhc...@gmail.com>
Subject Re: Review Request 32757: [5/5] Added a memory statistics test for writeback.
Date Wed, 03 Jun 2015 23:06:35 GMT


> On April 8, 2015, 6:44 p.m., Ian Downes wrote:
> > src/tests/memory_test_helper.cpp, lines 297-300
> > <https://reviews.apache.org/r/32757/diff/1/?file=913069#file913069line297>
> >
> >     What happens to this test if /tmp is a tmpfs?

Yeah, with /tmp mounted as tmpfs, 'writeback' is 0. 

To account for this, I can check if any of the parent directories of the working directory
is in the mount table entries and mounted as tmpfs

but that's probably more code than the test itself, so I am more inclined to just document
the assumption in the comment, if it is not common in reality that /tmp is tmpfs?


- Chi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32757/#review79394
-----------------------------------------------------------


On June 3, 2015, 11:05 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32757/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 11:05 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Bugs: mesos-2572
>     https://issues.apache.org/jira/browse/mesos-2572
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a memory statistics test for writeback.
> 
> 
> Diffs
> -----
> 
>   src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a 
>   src/tests/memory_test_helper.hpp 11712d7f378d9426f160d53b0387c698a28a4207 
>   src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 
> 
> Diff: https://reviews.apache.org/r/32757/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message