mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bartek Plotka" <bwplo...@gmail.com>
Subject Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.
Date Wed, 03 Jun 2015 21:18:15 GMT


> On June 3, 2015, 9:06 p.m., Niklas Nielsen wrote:
> > Do you want to add a test to verify that this works? :)

Definitely will do that in next patch (:


- Bartek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34980/#review86464
-----------------------------------------------------------


On June 3, 2015, 9:16 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34980/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 9:16 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
> 
> 
> Bugs: MESOS-2773
>     https://issues.apache.org/jira/browse/MESOS-2773
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Pass callback to the resource estimator to retrieve ResourceUsage from Resource Monitor
on demand.
> 
> This is neccessary, since ResourceEstimator needs data (current statistics for each executor)
on which it will base its slack predictions.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/resource_estimator.hpp e7f5decdabdfc75587d784a08a98c62ffdfc2909

>   src/slave/resource_estimators/noop.hpp 2234ed6da17346c74c2e232ff9eae501531515e1 
>   src/slave/resource_estimators/noop.cpp 3fb44d66cc4b53b4b5b12d14329c6ebdff3a8985 
>   src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 
>   src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
>   src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/34980/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message