mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 34534: Reflected in documentation that isolators are only relevant for Mesos Containerizer.
Date Wed, 03 Jun 2015 17:09:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34534/#review86433
-----------------------------------------------------------



docs/configuration.md
<https://reviews.apache.org/r/34534/#comment138425>

    I think this might be confusing to users.
    The DockerContainerizer also supports cgroups/cpu and cgroups/mem but not via our own
isolators but by passing certain flags to the Docker daemon.
    
    I think we should say this flag/configuration only applies to the MesosContainerizer instead
of mechanisms.


- Timothy Chen


On May 21, 2015, 8:45 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34534/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 8:45 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2758
>     https://issues.apache.org/jira/browse/MESOS-2758
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Reflected in documentation that isolators flags are only relevant for Mesos Containerizer.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b 
>   src/slave/flags.cpp b5e25186dad36bc1306cc6ecb268aba951a18f7e 
> 
> Diff: https://reviews.apache.org/r/34534/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message