mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 34962: Moved NoopResourceEstimator to a separate file.
Date Tue, 02 Jun 2015 23:49:27 GMT


> On June 2, 2015, 11:24 p.m., Niklas Nielsen wrote:
> > Should we name the 'resource_estimator' directory 'resource_estimators' like we
name the directory isolators?
> > 
> > I am fine with either; just wanted to get a feel for what pattern we want to go
with (the containerizer directory is in singular)
> > 
> > Otherwise, LGTM
> 
> Jie Yu wrote:
>     Hum, seems that we use plural more often than singular (src/tests, src/credentials,
src/files, etc.)

OK, I think 'containerizer' is a legacy issue (there was only one containerizer at that time)


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/#review86315
-----------------------------------------------------------


On June 2, 2015, 11:15 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34962/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 11:15 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved NoopResourceEstimator to a separate file.
> 
> As we're going to introduce more resource estimators in the code base, it makes sense
to put them into a directory.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 081185bb28fa58c8fe0b1ffa8db6599def56e85b 
>   src/examples/test_resource_estimator_module.cpp df85978f2beeccd0cccd893f13a8a0eeacd15e23

>   src/local/local.cpp 84f73e21e66e7a654b6b09f6a57a70a1ccc34b40 
>   src/slave/main.cpp e3a45f4dfa0c8cc5d28d795f42bdc8cd14b7b10d 
>   src/slave/resource_estimator.hpp 717804d65072a55e6c2bead14ab17be7fec57077 
>   src/slave/resource_estimator.cpp a67640c3878c5707b8ef39c0750711c619680a39 
>   src/slave/resource_estimator/noop.cpp PRE-CREATION 
>   src/tests/cluster.hpp 7370c77de68d3a13340a69f6e794d97306d4bbb6 
> 
> Diff: https://reviews.apache.org/r/34962/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message