mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bartek Plotka" <bwplo...@gmail.com>
Subject Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage
Date Tue, 02 Jun 2015 22:06:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/
-----------------------------------------------------------

(Updated June 2, 2015, 10:06 p.m.)


Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon
Konefal, and Vinod Kone.


Summary (updated)
-----------------

Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage


Bugs: MESOS-2772
    https://issues.apache.org/jira/browse/MESOS-2772


Repository: mesos


Description
-------

Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
Reused old ResoureUsage in message mesos.proto

NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator
and QoSController.
Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's
not used anywhere else.


Diffs (updated)
-----

  include/mesos/mesos.proto 5cf81e20bc77288eb4c183722c608827b5000cb4 
  src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225 
  src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e 

Diff: https://reviews.apache.org/r/34748/diff/


Testing
-------

make check


Thanks,

Bartek Plotka


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message